ref(analytics): Transform analytics events for TET-834 #95214

constantinius · 2025-07-10T09:16:49Z

Transform event classes to use @analytics.eventclass decorator
Transform analytics.record calls to use event class instances
Update imports as needed

Closes TET-834

- Transform event classes to use @analytics.eventclass decorator - Transform analytics.record calls to use event class instances - Update imports as needed Closes TET-834

codecov · 2025-07-11T07:26:50Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #95214      +/-   ##
==========================================
- Coverage   85.40%   80.33%   -5.08%     
==========================================
  Files       10478    10468      -10     
  Lines      605935   605079     -856     
  Branches    23673    23642      -31     
==========================================
- Hits       517488   486067   -31421     
- Misses      88083   118652   +30569     
+ Partials      364      360       -4

cursor

Bug: Type Mismatch in Analytics Event Classes

Analytics event classes declare ID fields (user_id, organization_id, sentry_app_id, sentry_app_installation_id) as str types. However, the calling code consistently passes integer values (e.g., user.id, organization.id, sentry_app_installation.id). This type mismatch, introduced by the recent refactor to decorator-based analytics with type annotations, could lead to runtime type validation errors.

src/sentry/analytics/events/sentry_app_installation_token_created.py#L5-L9

sentry/src/sentry/analytics/events/sentry_app_installation_token_created.py

Lines 5 to 9 in 2ef2970

    
           class SentryAppInstallationTokenCreated(analytics.Event): 
        
               user_id: str 
        
               organization_id: str 
        
               sentry_app_installation_id: str 
        
               sentry_app: str

src/sentry/analytics/events/sentry_app_created.py#L5-L8

sentry/src/sentry/analytics/events/sentry_app_created.py

Lines 5 to 8 in 2ef2970

    
           class SentryAppCreatedEvent(analytics.Event): 
        
               user_id: str 
        
               organization_id: str 
        
               sentry_app: str

src/sentry/analytics/events/sentry_app_deleted.py#L5-L8

sentry/src/sentry/analytics/events/sentry_app_deleted.py

Lines 5 to 8 in 2ef2970

    
           class SentryAppDeletedEvent(analytics.Event): 
        
               user_id: str 
        
               organization_id: str 
        
               sentry_app: str

src/sentry/analytics/events/sentry_app_installed.py#L5-L8

sentry/src/sentry/analytics/events/sentry_app_installed.py

Lines 5 to 8 in 2ef2970

    
           class SentryAppInstalledEvent(analytics.Event): 
        
               user_id: str 
        
               organization_id: str 
        
               sentry_app: str

src/sentry/analytics/events/sentry_app_installation_updated.py#L5-L8

sentry/src/sentry/analytics/events/sentry_app_installation_updated.py

Lines 5 to 8 in 2ef2970

    
           class SentryAppInstallationUpdatedEvent(analytics.Event): 
        
               sentry_app_installation_id: str 
        
               sentry_app_id: str 
        
               organization_id: str

src/sentry/analytics/events/alert_rule_ui_component_webhook_sent.py#L6-L8

sentry/src/sentry/analytics/events/alert_rule_ui_component_webhook_sent.py

Lines 6 to 8 in 2ef2970

    
           # organization_id refers to the organization that installed the sentryapp 
        
           organization_id: str 
        
           sentry_app_id: str

src/sentry/analytics/events/sentry_app_token_exchanged.py#L5-L6

sentry/src/sentry/analytics/events/sentry_app_token_exchanged.py

Lines 5 to 6 in 2ef2970

    
           class SentryAppTokenExchangedEvent(analytics.Event): 
        
               sentry_app_installation_id: str

src/sentry/analytics/events/internal_integration_created.py#L5-L7

sentry/src/sentry/analytics/events/internal_integration_created.py

Lines 5 to 7 in 2ef2970

    
           class InternalIntegrationCreatedEvent(analytics.Event): 
        
               user_id: str 
        
               organization_id: str

src/sentry/analytics/events/sentry_app_uninstalled.py#L5-L7

sentry/src/sentry/analytics/events/sentry_app_uninstalled.py

Lines 5 to 7 in 2ef2970

    
           class SentryAppUninstalledEvent(analytics.Event): 
        
               user_id: str 
        
               organization_id: str

src/sentry/analytics/events/sentry_app_updated.py#L5-L7

sentry/src/sentry/analytics/events/sentry_app_updated.py

Lines 5 to 7 in 2ef2970

    
           class SentryAppUpdatedEvent(analytics.Event): 
        
               user_id: str 
        
               organization_id: str

src/sentry/analytics/events/sentry_app_schema_validation_error.py#L6-L10

sentry/src/sentry/analytics/events/sentry_app_schema_validation_error.py

Lines 6 to 10 in 2ef2970

    
           schema: str 
        
           user_id: str 
        
           sentry_app_id: str | None = None 
        
           sentry_app_name: str 
        
           organization_id: str

src/sentry/analytics/events/sentry_app_installation_token_deleted.py#L5-L8

sentry/src/sentry/analytics/events/sentry_app_installation_token_deleted.py

Lines 5 to 8 in 2ef2970

    
           class SentryAppInstallationTokenDeleted(analytics.Event): 
        
               user_id: str 
        
               organization_id: str 
        
               sentry_app_installation_id: str

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

ref(analytics): Transform analytics events for TET-834

42e7e29

- Transform event classes to use @analytics.eventclass decorator - Transform analytics.record calls to use event class instances - Update imports as needed Closes TET-834

constantinius requested review from a team as code owners July 10, 2025 09:16

github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 10, 2025

🛠️ apply pre-commit fixes

9a79120

vercel bot deployed to Preview July 10, 2025 09:19 View deployment

This comment was marked as outdated.

Sign in to view

Merge branch 'master' into constantinius/ref/analytics/tet-834

2ef2970

vercel bot deployed to Preview July 11, 2025 07:26 View deployment

cursor bot reviewed Jul 11, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

ref(analytics): Transform analytics events for TET-834 #95214

ref(analytics): Transform analytics events for TET-834 #95214

Uh oh!

constantinius commented Jul 10, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

codecov bot commented Jul 11, 2025

Uh oh!

cursor bot left a comment

Uh oh!

Uh oh!

	class SentryAppInstallationTokenCreated(analytics.Event):
	user_id: str
	organization_id: str
	sentry_app_installation_id: str
	sentry_app: str

	class SentryAppCreatedEvent(analytics.Event):
	user_id: str
	organization_id: str
	sentry_app: str

	class SentryAppDeletedEvent(analytics.Event):
	user_id: str
	organization_id: str
	sentry_app: str

	class SentryAppInstalledEvent(analytics.Event):
	user_id: str
	organization_id: str
	sentry_app: str

	class SentryAppInstallationUpdatedEvent(analytics.Event):
	sentry_app_installation_id: str
	sentry_app_id: str
	organization_id: str

	# organization_id refers to the organization that installed the sentryapp
	organization_id: str
	sentry_app_id: str

	class SentryAppTokenExchangedEvent(analytics.Event):
	sentry_app_installation_id: str

	class InternalIntegrationCreatedEvent(analytics.Event):
	user_id: str
	organization_id: str

	class SentryAppUninstalledEvent(analytics.Event):
	user_id: str
	organization_id: str

	class SentryAppUpdatedEvent(analytics.Event):
	user_id: str
	organization_id: str

	schema: str
	user_id: str
	sentry_app_id: str \| None = None
	sentry_app_name: str
	organization_id: str

	class SentryAppInstallationTokenDeleted(analytics.Event):
	user_id: str
	organization_id: str
	sentry_app_installation_id: str

Uh oh!

ref(analytics): Transform analytics events for TET-834 #95214

Are you sure you want to change the base?

ref(analytics): Transform analytics events for TET-834 #95214

Uh oh!

Conversation

constantinius commented Jul 10, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

codecov bot commented Jul 11, 2025

Codecov Report

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Bug: Type Mismatch in Analytics Event Classes

Uh oh!

Uh oh!